Allow spaces inside placeholder in target issued acknowledgement label #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thjaeckle
requested changes
Sep 11, 2023
There was a problem hiding this comment.
@dimabarbul I added my review findings as comments.
Thanks a lot for finding and directly fixing 👍
base/model/src/main/java/org/eclipse/ditto/base/model/acks/AcknowledgementLabels.java
Outdated
Show resolved
Hide resolved
base/model/src/test/java/org/eclipse/ditto/base/model/acks/AcknowledgementLabelsTest.java
Outdated
Show resolved
Hide resolved
base/model/src/main/java/org/eclipse/ditto/base/model/acks/AcknowledgementLabels.java
Outdated
Show resolved
Hide resolved
dimabarbul
force-pushed
the
issued-acknowledgement-label-allow-spaces-in-placeholder
branch
from
f4d6238 to
d661060
Compare
thjaeckle
approved these changes
Sep 11, 2023
dimabarbul
deleted the
issued-acknowledgement-label-allow-spaces-in-placeholder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issued acknowledgement label for target must start with connection ID. This can be achieved by using
connection:idplaceholder. Usually placeholders allow using spaces inside of (right after opening and right before closing) curly brackets, for example,{{ connection:id }}. But validation does not allow spaces in placeholder in target issued acknowledgement label.