GLSP-1181: Fix support for simultaneously open diagrams

Fixes eclipse-glsp/glsp#1181 Also: Update changelog to reflect latest changes
eclipse-glsp · Nov 29, 2023 · e55b121 · e55b121
1 parent 2247067
commit e55b121
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,12 +1,16 @@
 # Eclipse GLSP Client Changelog
 
-## v2.10.0 - active
+## v2.1.0 - active
 
 ### Changes
 
+-   [diagram] Fix a bug that prevented correct rendering of projection bars when using `GLSPProjectionView` [#298](https://github.com/eclipse-glsp/glsp-client/pull/298)
+-   [a11y] Improved responsibility and feedback when resizing or moving diagram elements with keyboard-only commands [#295](https://github.com/eclipse-glsp/glsp-client/pull/295)
+-   [diagram] Extends `configureDiagramOptions` function to also allow partial configuration of `ViewerOptions` [#296](https://github.com/eclipse-glsp/glsp-client/pull/296)
 -   [diagram] Remove unused handleSetContextActions from ToolPalette [#301](https://github.com/eclipse-glsp/glsp-client/pull/301)
-
-### Breaking Changes
+-   [diagram] Deprecate `ISModelRootListener` API in favor of `IGModelRootListener` [#303](https://github.com/eclipse-glsp/glsp-client/pull/303)
+-   [diagram] Ensure that the suggestion container position of the `AutoCompleteWidget` is rendered correctly [#304](https://github.com/eclipse-glsp/glsp-client/pull/304)
+-   [feature] Extend `ToolPalette`/`CreateOperation` API to support rendering of preview/ghost elements when creating new nodes [#301](https://github.com/eclipse-glsp/glsp-client/pull/301)
 
 ## [v2.0.0 - 14/10/2023](https://github.com/eclipse-glsp/glsp-client/releases/tag/v2.0.0)
 

diff --git a/packages/protocol/src/client-server-protocol/jsonrpc/base-jsonrpc-glsp-client.ts b/packages/protocol/src/client-server-protocol/jsonrpc/base-jsonrpc-glsp-client.ts
@@ -36,6 +36,11 @@ export class BaseJsonrpcGLSPClient implements GLSPClient {
         return this.onServerInitializedEmitter.event;
     }
 
+    protected onActionMessageNotificationEmitter = new Emitter<ActionMessage>();
+    protected get onActionMessageNotification(): Event<ActionMessage> {
+        return this.onActionMessageNotificationEmitter.event;
+    }
+
     constructor(options: JsonrpcGLSPClient.Options) {
         Object.assign(this, options);
         this.state = ClientState.Initial;
@@ -66,7 +71,7 @@ export class BaseJsonrpcGLSPClient implements GLSPClient {
     }
 
     onActionMessage(handler: ActionMessageHandler, clientId?: string): Disposable {
-        return this.checkedConnection.onNotification(JsonrpcGLSPClient.ActionMessageNotification, msg => {
+        return this.onActionMessageNotification(msg => {
             if (!clientId || msg.clientId === clientId) {
                 handler(msg);
             }
@@ -91,6 +96,9 @@ export class BaseJsonrpcGLSPClient implements GLSPClient {
         try {
             this.state = ClientState.Starting;
             const connection = await this.resolveConnection();
+            connection.onNotification(JsonrpcGLSPClient.ActionMessageNotification, msg =>
+                this.onActionMessageNotificationEmitter.fire(msg)
+            );
             connection.listen();
             this.resolvedConnection = connection;
             this.state = ClientState.Running;
@@ -113,6 +121,7 @@ export class BaseJsonrpcGLSPClient implements GLSPClient {
             connection.dispose();
             this.state = ClientState.Stopped;
             this.onStop = undefined;
+            this.onActionMessageNotificationEmitter.dispose();
             this.connectionPromise = undefined;
             this.resolvedConnection = undefined;
         }));