Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayoutEngine: LayoutConfigurator should be layout time #1196

Open
MichelSc opened this issue Dec 15, 2023 · 1 comment
Open

LayoutEngine: LayoutConfigurator should be layout time #1196

MichelSc opened this issue Dec 15, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature

Comments

@MichelSc
Copy link

The LayoutConfigurator allows to pass layout parameters for a node, an edge or the graph: OK.

The LayoutConfigurator is created at diagram load time via the options of configureELKLayoutModule: NOK for 2 reasons:

  • the LayoutEngine only need the configurator at layout time
  • layouting parameters might only be known at layout time
    • in our case, we want to freeze the non-selected nodes (or to limit the layout to the selected nodes)

Suggestion: add an optional parameter configurator:LayoutConfigurator in LayoutEngine.layout.

@MichelSc MichelSc added the enhancement New feature or request label Dec 15, 2023
@planger
Copy link
Member

planger commented Jan 25, 2024

@MichelSc Thank you very much for proposing this your feature request! And sorry for the delayed response. For some reason the issue wasn't correctly added to our project board.

It's an interesting idea, but at the moment, it's not part of our immediate roadmap. However, we're always excited about community contributions. If you're keen on implementing this feature, we're more than happy to assist you in every step of the journey.

Please note that there is also #1173 which we do have on our roadmap (upper third of backlog). I'm not quite sure how fast we can get to it, but we do like to address #1173.

@planger planger added help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature
Projects
None yet
Development

No branches or pull requests

2 participants