-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context Menu for VSCode integration #414
Comments
Generic context menu support in webviews for VS Code is provided with this PR: microsoft/vscode#154524 |
I have played around with the
In general, it would be better to use a custom context menu implementation that lives in the webview. This would give access to all diagram related information and also enables dynamic menu items provided by the server. Regarding styling it could be aligned with the default vscode context menu (same size, css keys etc.) so that it integrates fluently with the rest of the IDE. For now let's move this into the back log until we have a concrete use case and/or sponsor for this feature. |
Remove context menu module for now as it is not supported in VS Code (eclipse-glsp/glsp#414) and causes focus issues
Remove context menu module for now as it is not supported in VS Code (eclipse-glsp/glsp#414) and causes focus issues
Currently it's not possible to contribute to the context menu of a custom editor. In fact, the context menu for webviews is completely disabled. As a workaround the GLSP Diagram Menu has been contributed to the "editor menu" in eclipse-glsp/glsp-vscode-integration#15.
There is an open issue for this microsoft/vscode#54285. However, this issue is open since 2018 and has not been tackled yet. It's unlikley that it will be resolved soon. If we really need a context menu we'd have to implement a custom solution.
@lforst already has provided MVP for a context menu implementation that could be reused here:
https://github.com/lforst/glsp-vscode-integration/tree/lforst/context-menu
The text was updated successfully, but these errors were encountered: