From 5cb9eff23310dee4cc513d2a4cde85e9d548a513 Mon Sep 17 00:00:00 2001 From: Michael Bangas Date: Mon, 14 Apr 2025 13:09:40 +0200 Subject: [PATCH 1/2] add all svgs to org.eclipse.ui.editors This commit adds SVGs for all icons in the bundle `org.eclipse.ui.editors` except for the following as it is not available as SVG yet: etool16/next_edit_pos --- .../META-INF/MANIFEST.MF | 1 + .../icons/full/elcl16/collapseall.svg | 223 ++++++++ .../icons/full/elcl16/expandall.svg | 334 +++++++++++ .../icons/full/etool16/last_edit_pos.svg | 167 ++++++ .../full/etool16/new_untitled_text_file.svg | 520 ++++++++++++++++++ .../icons/full/etool16/next_nav.svg | 374 +++++++++++++ .../icons/full/etool16/prev_nav.svg | 362 ++++++++++++ .../icons/full/obj16/file_obj.svg | 294 ++++++++++ .../icons/full/obj16/quick_assist_obj.svg | 311 +++++++++++ .../icons/full/obj16/quick_fix_error_obj.svg | 250 +++++++++ .../icons/full/obj16/quick_fix_info_obj.svg | 243 ++++++++ .../full/obj16/quick_fix_warning_obj.svg | 329 +++++++++++ bundles/org.eclipse.ui.editors/plugin.xml | 22 +- 13 files changed, 3419 insertions(+), 11 deletions(-) create mode 100644 bundles/org.eclipse.ui.editors/icons/full/elcl16/collapseall.svg create mode 100644 bundles/org.eclipse.ui.editors/icons/full/elcl16/expandall.svg create mode 100644 bundles/org.eclipse.ui.editors/icons/full/etool16/last_edit_pos.svg create mode 100644 bundles/org.eclipse.ui.editors/icons/full/etool16/new_untitled_text_file.svg create mode 100644 bundles/org.eclipse.ui.editors/icons/full/etool16/next_nav.svg create mode 100644 bundles/org.eclipse.ui.editors/icons/full/etool16/prev_nav.svg create mode 100644 bundles/org.eclipse.ui.editors/icons/full/obj16/file_obj.svg create mode 100644 bundles/org.eclipse.ui.editors/icons/full/obj16/quick_assist_obj.svg create mode 100644 bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_error_obj.svg create mode 100644 bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_info_obj.svg create mode 100644 bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_warning_obj.svg diff --git a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF index 5e46a06a143..e2c6de2ac1c 100644 --- a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF +++ b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF @@ -31,3 +31,4 @@ Require-Bundle: org.eclipse.jdt.annotation;bundle-version="2.3";resolution:=optional Bundle-RequiredExecutionEnvironment: JavaSE-17 Automatic-Module-Name: org.eclipse.ui.editors +Require-Capability: eclipse.swt;filter:="(image.format=svg)" diff --git a/bundles/org.eclipse.ui.editors/icons/full/elcl16/collapseall.svg b/bundles/org.eclipse.ui.editors/icons/full/elcl16/collapseall.svg new file mode 100644 index 00000000000..587c3c3497e --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/elcl16/collapseall.svg @@ -0,0 +1,223 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/icons/full/elcl16/expandall.svg b/bundles/org.eclipse.ui.editors/icons/full/elcl16/expandall.svg new file mode 100644 index 00000000000..62cde2723c1 --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/elcl16/expandall.svg @@ -0,0 +1,334 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/icons/full/etool16/last_edit_pos.svg b/bundles/org.eclipse.ui.editors/icons/full/etool16/last_edit_pos.svg new file mode 100644 index 00000000000..fd81f726c71 --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/etool16/last_edit_pos.svg @@ -0,0 +1,167 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/icons/full/etool16/new_untitled_text_file.svg b/bundles/org.eclipse.ui.editors/icons/full/etool16/new_untitled_text_file.svg new file mode 100644 index 00000000000..90215d89450 --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/etool16/new_untitled_text_file.svg @@ -0,0 +1,520 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/icons/full/etool16/next_nav.svg b/bundles/org.eclipse.ui.editors/icons/full/etool16/next_nav.svg new file mode 100644 index 00000000000..009ffc07d2f --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/etool16/next_nav.svg @@ -0,0 +1,374 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/icons/full/etool16/prev_nav.svg b/bundles/org.eclipse.ui.editors/icons/full/etool16/prev_nav.svg new file mode 100644 index 00000000000..04445013456 --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/etool16/prev_nav.svg @@ -0,0 +1,362 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/icons/full/obj16/file_obj.svg b/bundles/org.eclipse.ui.editors/icons/full/obj16/file_obj.svg new file mode 100644 index 00000000000..fbad0ece47f --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/obj16/file_obj.svg @@ -0,0 +1,294 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_assist_obj.svg b/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_assist_obj.svg new file mode 100644 index 00000000000..17e107a2f7f --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_assist_obj.svg @@ -0,0 +1,311 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_error_obj.svg b/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_error_obj.svg new file mode 100644 index 00000000000..8476cd0f08a --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_error_obj.svg @@ -0,0 +1,250 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_info_obj.svg b/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_info_obj.svg new file mode 100644 index 00000000000..86e7f60c065 --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_info_obj.svg @@ -0,0 +1,243 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_warning_obj.svg b/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_warning_obj.svg new file mode 100644 index 00000000000..0a68d026638 --- /dev/null +++ b/bundles/org.eclipse.ui.editors/icons/full/obj16/quick_fix_warning_obj.svg @@ -0,0 +1,329 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/bundles/org.eclipse.ui.editors/plugin.xml b/bundles/org.eclipse.ui.editors/plugin.xml index ce60714504a..23795dcdab5 100644 --- a/bundles/org.eclipse.ui.editors/plugin.xml +++ b/bundles/org.eclipse.ui.editors/plugin.xml @@ -153,11 +153,11 @@ + icon="$nl$/icons/full/elcl16/collapseall.svg"> + icon="$nl$/icons/full/elcl16/expandall.svg"> @@ -266,7 +266,7 @@ point="org.eclipse.ui.editors"> @@ -477,7 +477,7 @@ point="org.eclipse.ui.newWizards"> @@ -525,7 +525,7 @@ class="org.eclipse.ui.internal.editors.text.NextPulldownActionDelegate" definitionId="org.eclipse.ui.navigate.next" disabledIcon="$nl$/icons/full/dtool16/next_nav.png" - icon="$nl$/icons/full/etool16/next_nav.png" + icon="$nl$/icons/full/etool16/next_nav.svg" label="%goToNextAnnotation.label" retarget="true" tooltip="%goToNextAnnotation.tooltip"> @@ -554,7 +554,7 @@ class="org.eclipse.ui.texteditor.GotoLastEditPositionAction" definitionId="org.eclipse.ui.edit.text.gotoLastEditPosition" disabledIcon="$nl$/icons/full/dtool16/last_edit_pos.png" - icon="$nl$/icons/full/etool16/last_edit_pos.png" + icon="$nl$/icons/full/etool16/last_edit_pos.svg" helpContextId="org.eclipse.ui.goto_last_edit_position_action_context" label="%goToLastEditPosition.label" menubarPath="navigate/" @@ -608,7 +608,7 @@ annotationType="org.eclipse.ui.workbench.texteditor.spelling" label="%spelling.label" symbolicIcon="warning" - quickFixIcon="$nl$/icons/full/obj16/quick_fix_warning_obj.png" + quickFixIcon="$nl$/icons/full/obj16/quick_fix_warning_obj.svg" presentationLayer="5" contributesToHeader="true" colorPreferenceKey="spellingIndicationColor" @@ -640,7 +640,7 @@ colorPreferenceKey="errorIndicationColor" showInNextPrevDropdownToolbarActionKey="showErrorInNextPrevDropdownToolbarAction" symbolicIcon="error" - quickFixIcon="$nl$/icons/full/obj16/quick_fix_error_obj.png" + quickFixIcon="$nl$/icons/full/obj16/quick_fix_error_obj.svg" isGoToNextNavigationTargetKey="isErrorGoToNextNavigationTarget" isGoToNextNavigationTarget="true" isGoToPreviousNavigationTargetKey="isErrorGoToPreviousNavigationTarget" @@ -666,7 +666,7 @@ colorPreferenceKey="warningIndicationColor" showInNextPrevDropdownToolbarActionKey="showWarningInNextPrevDropdownToolbarAction" symbolicIcon="warning" - quickFixIcon="$nl$/icons/full/obj16/quick_fix_warning_obj.png" + quickFixIcon="$nl$/icons/full/obj16/quick_fix_warning_obj.svg" isGoToNextNavigationTargetKey="isWarningGoToNextNavigationTarget" isGoToNextNavigationTarget="true" isGoToPreviousNavigationTargetKey="isWarningGoToPreviousNavigationTarget" @@ -704,7 +704,7 @@ contributesToHeader="false" colorPreferenceValue="130,160,190" overviewRulerPreferenceValue="true" - quickFixIcon="$nl$/icons/full/obj16/quick_fix_info_obj.png" + quickFixIcon="$nl$/icons/full/obj16/quick_fix_info_obj.svg" textStylePreferenceKey="infoTextStyle" textStylePreferenceValue="SQUIGGLES"> From 54326f9c95c708ce937bfa908fa30d3b29f8be27 Mon Sep 17 00:00:00 2001 From: Heiko Klare Date: Thu, 24 Apr 2025 13:51:44 +0200 Subject: [PATCH 2/2] Remove explicit disabled icons from org.eclipse.ui.editors Use on-the-fly-generated disabled version of SVG-rasterized icons instead. --- bundles/org.eclipse.ui.editors/plugin.xml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/bundles/org.eclipse.ui.editors/plugin.xml b/bundles/org.eclipse.ui.editors/plugin.xml index 23795dcdab5..3d0917e31d7 100644 --- a/bundles/org.eclipse.ui.editors/plugin.xml +++ b/bundles/org.eclipse.ui.editors/plugin.xml @@ -152,7 +152,6 @@