Workaround for unexpected scrollbars in MultipleHyperlinkPresenter

[akoch-yatta]

This PR adds two additional points to the width and height when calculating the size of the composite containing the Hyperlinks in the MultipleHyperlinkPresenter. This serves as a workaround for a current limitation in the SWT implementation on Windows. With certain zoom settings (e.g., 125%, 175% or 225%), the calculated size may be too small, causing the Composite to show Scrollbars, although it calculated to not need scrollbars. This additional width/height is only added for windows and when no scrollbars should be thrown. This is intended as a temporary workaround.

This is intended as a temporary workaround. If we merge this, we should either revert it after the release to reintroduce the issue or have hopefully a proper fix inside of SWT. Still, as it affects a quite central element, I would propose to merge this PR.

How to test

Use this Snippet and open it on a 225% monitor.

package test;

public class TestClass {
	public static void main(String[] args) {
		// TODO Auto-generated method stub
	}
}

Without the PR you will see:

[github-actions]

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 35m 45s ⏱️ - 3m 31s
 7 925 tests ±0   7 697 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 862 runs  ±0  23 114 ✅ ±0  748 💤 ±0  0 ❌ ±0 

Results for commit 42d9884. ± Comparison against base commit c741652.

♻️ This comment has been updated with latest results.

[HeikoKlare]

I've tested the workaround in a current SDK. It properly solves the mentioned scrollbar issue at all zooms that I was able to test (100, 125, 150, 175, 200, 225).

Since having those scrollbars would be annoying and significantly impact usability, this should go into RC1. I considers this safe to do because:

• The popup shell is self-contained, so the compensation values for autoscale rounding issues will not affect any enclosing widgets, layouts or the like. It will just slighly increase the shell size. And they are only applied when running on Windows, on which the changes have been tested.
• The zoom change listener will just reset the shell size. The shell is not manually resizable, so nothing can be overwritten here. It only happens on zoom change, thus if switching back to non-monitor-specific scaling, it would not even be executed.