Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHACL - support simple rdfs reasoner #1298

Closed
hmottestad opened this issue Feb 18, 2019 · 4 comments
Closed

SHACL - support simple rdfs reasoner #1298

hmottestad opened this issue Feb 18, 2019 · 4 comments
Assignees
@hmottestad
Labels
M2 Fixed in milestone 2 📦 SHACL affects the SHACL validator
Milestone
2.5.0

Comments

@hmottestad
Copy link
Contributor

Since SHACL is pushed as a replacement for spin it has a bunch of quirky features, such as an embedded reasoner that only supports rdfs:subClassOf and only works during validation and not on SPARQL queries that run on the validated data.
@hmottestad hmottestad added the 📦 SHACL affects the SHACL validator label Feb 18, 2019
@hmottestad hmottestad self-assigned this Feb 18, 2019
@hmottestad
Copy link
Contributor Author

Copy code from the schema chaching reasoner

@hmottestad
Copy link
Contributor Author

Forward chain the added and removed memory stores. Backwards chain the base sail. Set a connection wide Boolean field “validating” to enable the backwardschaining.

hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Feb 19, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1298 initial implementation of a rdfs reasoner fo…
5f32fc6 
…r the shacl engine

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad mentioned this issue Feb 19, 2019
Merged
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Feb 19, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1298 fix for dedupes
b40d91b 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Feb 19, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1298 minor cleanup
152ac17 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Feb 19, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1298 made rdfs reasoner configurable and added ba…
e70aa52 
…ck tests

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad added this to the 2.5.0 milestone Feb 19, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Feb 20, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1298 performance enhancement
9636ee8 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Feb 20, 2019
@hmottestad
Merge pull request #175 from eclipse/issues/1298_rdfs_reasoner_shacl
917f45d 
eclipse-rdf4j/rdf4j#1298 rdfs reasoner for the SHACL engine
@abrokenjester
Copy link
Contributor

@hmottestad I see a PR was merged, is this issue done?

@hmottestad
Copy link
Contributor Author

Yes

@abrokenjester abrokenjester added the M2 Fixed in milestone 2 label Feb 21, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Feb 24, 2019
@hmottestad
Merge branch 'develop' into feature/101_shacl_w3c_tests
46b646f 
* develop: (80 commits)
  eclipse-rdf4j/rdf4j#1298 performance enhancement
  eclipse-rdf4j/rdf4j#1298 made rdfs reasoner configurable and added back tests
  eclipse-rdf4j/rdf4j#1298 minor cleanup
  eclipse-rdf4j/rdf4j#1298 fix for dedupes
  eclipse-rdf4j/rdf4j#1298 initial implementation of a rdfs reasoner for the shacl engine
  eclipse-rdf4j/rdf4j#1297 implement requiresEvaluation
  eclipse-rdf4j/rdf4j#1297 change SPARQL order to improve performance
  eclipse-rdf4j/rdf4j#1297 update benchmarks
  eclipse-rdf4j/rdf4j#1111 hot fix caching broken after merging sh:class and also fix some tests
  hotfix benchmark
  eclipse-rdf4j/rdf4j#1111 optimizations for empty sail and bulk joining for previousStateConnection
  eclipse-rdf4j/rdf4j#1111 removed use of getPreviousStateConnection because it doesn't handle deleted, will need to think of something smarter here. Also fixed printing of plans.
  eclipse-rdf4j/rdf4j#1111 fixes for blank node support
  Moved test from testsuite to storage
  Fixes #1293 Allow Regex calls with non Var arguments be replaced with other string functions
  eclipse-rdf4j/rdf4j#1111 optimized imports
  eclipse-rdf4j/rdf4j#1111 fixed last edge case
  eclipse-rdf4j/rdf4j#1111 better support for OR
  eclipse-rdf4j/rdf4j#1111 fixed sh:or by doing a two pass for sh:or. Not quite done yet though.
  documentation and code cleanup
  ...

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>

# Conflicts:
#	shacl/src/test/java/org/eclipse/rdf4j/sail/shacl/Utils.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
M2 Fixed in milestone 2 📦 SHACL affects the SHACL validator
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@abrokenjester @hmottestad