diff --git a/packages/core/src/browser/quick-open/quick-pick-service-impl.ts b/packages/core/src/browser/quick-open/quick-pick-service-impl.ts index 9e0eac1baf967..4ec4aecd08504 100644 --- a/packages/core/src/browser/quick-open/quick-pick-service-impl.ts +++ b/packages/core/src/browser/quick-open/quick-pick-service-impl.ts @@ -43,6 +43,7 @@ export class QuickPickServiceImpl implements QuickPickService { private readonly onDidChangeSelectionEmitter = new Emitter<(string | QuickPickValue)[]>(); readonly onDidChangeSelection = this.onDidChangeSelectionEmitter.event; + // TODO when to release last elements? private elements: (string | QuickPickItem)[] = []; @postConstruct() @@ -81,8 +82,8 @@ export class QuickPickServiceImpl implements QuickPickService { if (this.elements !== elements) { elements = this.elements; items = this.toItems(elements, resolve); - acceptor(items); } + acceptor(items); if (savedValue !== value) { this.onDidChangeValueEmitter.fire(value); savedValue = value;