Now using child_process.fork() to run node-based debug adapters; also…

… handles Electron Signed-off-by: Eyal Barlev <eyal.barlev@sap.com>
eclipse-theia · Jul 18, 2019 · 6e6bba1 · 6e6bba1
1 parent 32806e1
commit 6e6bba1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/packages/debug/src/common/debug-model.ts b/packages/debug/src/common/debug-model.ts
@@ -70,6 +70,7 @@ export interface DebugAdapterSpawnExecutable {
  */
 export interface DebugAdapterForkExecutable {
     modulePath: string;
+    execArgv?: string[];
     args?: string[];
 }
 

diff --git a/packages/debug/src/node/debug-adapter-factory.ts b/packages/debug/src/node/debug-adapter-factory.ts
@@ -35,9 +35,11 @@ import {
     CommunicationProvider,
     DebugAdapterSession,
     DebugAdapterSessionFactory,
-    DebugAdapterFactory
+    DebugAdapterFactory,
+    DebugAdapterForkExecutable
 } from '../common/debug-model';
 import { DebugAdapterSessionImpl } from './debug-adapter-session';
+import { environment } from '@theia/application-package';
 
 /**
  * [DebugAdapterFactory](#DebugAdapterFactory) implementation based on
@@ -67,10 +69,12 @@ export class LaunchBasedDebugAdapterFactory implements DebugAdapterFactory {
             !!forkOptions && !!forkOptions.modulePath;
 
         const processOptions: RawProcessOptions | RawForkOptions = { ...executable };
-        const options = { stdio: ['pipe', 'pipe', 2] };
+        const options: { stdio: (string | number)[], env?: object, execArgv?: string[] } = { stdio: ['pipe', 'pipe', 2] };
 
         if (isForkOptions(processOptions)) {
             options.stdio.push('ipc');
+            options.env = environment.electron.runAsNodeEnv();
+            options.execArgv = (executable as DebugAdapterForkExecutable).execArgv;
         }
 
         processOptions.options = options;

diff --git a/packages/debug/src/node/vscode/vscode-debug-adapter-contribution.ts b/packages/debug/src/node/vscode/vscode-debug-adapter-contribution.ts
@@ -233,10 +233,10 @@ export abstract class AbstractVSCodeDebugAdapterContribution implements DebugAda
         const runtimeArgs = info && info.runtimeArgs || contribution.runtimeArgs || [];
         if (runtime === 'node') {
             const modulePath = program;
-            const args = [...runtimeArgs, ...programArgs];
             return {
-                modulePath,
-                args
+                modulePath: modulePath,
+                execArgv: runtimeArgs,
+                args: programArgs
             };
         } else {
             const command = runtime ? runtime : program;