From 8764defad4644078b8d843c452c1c0b69377f0dd Mon Sep 17 00:00:00 2001 From: Dennis Huebner Date: Thu, 19 Sep 2024 16:38:22 +0200 Subject: [PATCH] Prefer Python 3.11 when running in CI --- .../src/tests/theia-notebook-editor.test.ts | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/examples/playwright/src/tests/theia-notebook-editor.test.ts b/examples/playwright/src/tests/theia-notebook-editor.test.ts index 5d083e6ed1d8a..1a94915482a3c 100644 --- a/examples/playwright/src/tests/theia-notebook-editor.test.ts +++ b/examples/playwright/src/tests/theia-notebook-editor.test.ts @@ -22,6 +22,9 @@ import { TheiaNotebookEditor } from '../theia-notebook-editor'; import { TheiaWorkspace } from '../theia-workspace'; import path = require('path'); +// See .github/workflows/playwright.yml for preferred python version +const preferredKernel = process.env.CI ? 'Python 3.11' : 'Python 3'; + test.describe('Theia Notebook Editor interaction', () => { let app: TheiaApp; @@ -49,15 +52,15 @@ test.describe('Theia Notebook Editor interaction', () => { console.log(msg); // Print available kernels, useful when running in CI. expect(kernels.length, msg).toBeGreaterThan(0); - const py3kernel = kernels.filter(kernel => kernel.match(/^Python 3/)); + const py3kernel = kernels.filter(kernel => kernel.match(new RegExp(`^${preferredKernel}`))); expect(py3kernel.length, msg).toBeGreaterThan(0); }); test('should select a kernel', async () => { editor = await app.openEditor('sample.ipynb', TheiaNotebookEditor); - await editor.selectKernel('Python 3'); + await editor.selectKernel(preferredKernel); const selectedKernel = await editor.selectedKernel(); - expect(selectedKernel).toMatch(/^Python 3/); + expect(selectedKernel).toMatch(new RegExp(`^${preferredKernel}`)); }); test('should add a new code cell', async () => { @@ -98,8 +101,8 @@ test.describe('Theia Notebook Cell interaction', () => { test.beforeEach(async () => { editor = await app.openEditor('sample.ipynb', TheiaNotebookEditor); const selectedKernel = await editor.selectedKernel(); - if (selectedKernel?.match(/^Python 3/) === null) { - await editor.selectKernel('Python 3'); + if (selectedKernel?.match(new RegExp(`^${preferredKernel}`)) === null) { + await editor.selectKernel(preferredKernel); } });