Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow definition of configuration folder in the application properties #14318

Closed
rschnekenbu opened this issue Oct 15, 2024 · 0 comments · Fixed by #14319
Closed

Allow definition of configuration folder in the application properties #14318

rschnekenbu opened this issue Oct 15, 2024 · 0 comments · Fixed by #14319
Assignees
Milestone

Comments

@rschnekenbu
Copy link
Contributor

Despite #13708, it is currently impossible to use the THEIA_CONFIG_DIR environment variable in a custom theia application.

In fact, the advised method for theia applications is to override the environment variable server and the getConfigDir() method. (see #4488 and https://github.com/eclipse-theia/theia/blob/master/doc/changelogs/CHANGELOG-2020.md#v0160---27022020)
In this case, all implemented logic about THEIA_CONFIG_DIR is ignored, as the config directory returned is always the one defined in the custom environment variable server.

Configuration folder could be set in the application props, so that any custom application could set its own folder. Default value for this one should be obviously '.theia' for compatibility reasons.

@rschnekenbu rschnekenbu self-assigned this Oct 15, 2024
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Oct 15, 2024
fixes eclipse-theia#14318

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Oct 15, 2024
…ation

fixes eclipse-theia#14318

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@jfaltermeier jfaltermeier added this to the 1.55.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants