Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[open file][find command] Unexpected search results #4537

Closed
AlexTugarev opened this issue Mar 12, 2019 · 4 comments · Fixed by #4549
Closed

[open file][find command] Unexpected search results #4537

AlexTugarev opened this issue Mar 12, 2019 · 4 comments · Fixed by #4549
Assignees
@akosyakov
Labels
bug bugs found in the application commands issues related to application commands

Comments

@AlexTugarev
Copy link
Contributor

If the search string is matched, I'd expect there would be no substring search results included.

2019-03-12 17 07 28

2019-03-12 17 06 40

/cc. @akosyakov
@akosyakov
Copy link
Member

Maybe related #4508

@akosyakov akosyakov added bug bugs found in the application commands issues related to application commands labels Mar 12, 2019
@akosyakov akosyakov self-assigned this Mar 13, 2019
@akosyakov
Copy link
Member

We enable separate substring matching by default. Looking at clients it is not really good default. I would like to make it configurable and disable by default. Objections?

@akosyakov
Copy link
Member

And there is apparently a race in quick file, looking into it as well.

@akosyakov
Copy link
Member

akosyakov commented Mar 13, 2019 •
edited
Loading

The file search also returns unrelated results:
Screen Shot 2019-03-13 at 09 08 17

Backend does absolute matching when frontend expects relative matches.

akosyakov added a commit that referenced this issue Mar 13, 2019
@akosyakov
[quick-open] disable separate fuzzy substring matching by default #4537
029c7d2 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 13, 2019
@akosyakov
[file-search] handle cancellation properly to avoid race conditions #…
b45ba43 
…4537

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 13, 2019
@akosyakov
fixup! [quick-open] disable separate fuzzy substring matching by defa…
fb4eb30 
…ult #4537
akosyakov added a commit that referenced this issue Mar 13, 2019
@akosyakov
[file-search] match against relative paths (not absolute) #4537
9bb5937 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Mar 13, 2019
Merged
akosyakov added a commit that referenced this issue Mar 13, 2019
@akosyakov
[quick-open] disable separate fuzzy substring matching by default #4537
f0b5126 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 13, 2019
@akosyakov
[file-search] handle cancellation properly to avoid race conditions #…
84576ff 
…4537

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 13, 2019
@akosyakov
[file-search] match against relative paths (not absolute) #4537
6aac747 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 13, 2019
@akosyakov
[quick-open] disable separate fuzzy substring matching by default #4537
ccb399d 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 13, 2019
@akosyakov
[file-search] handle cancellation properly to avoid race conditions #…
a2fb231 
…4537

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 13, 2019
@akosyakov
[file-search] match against relative paths (not absolute) #4537
3252a7b 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 14, 2019
@akosyakov
[quick-open] disable separate fuzzy substring matching by default #4537
89b2f6b 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 14, 2019
@akosyakov
[file-search] handle cancellation properly to avoid race conditions #…
265e12f 
…4537

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 14, 2019
@akosyakov
[file-search] match against relative paths (not absolute) #4537
e93d45a 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 15, 2019
@akosyakov
[quick-open] disable separate fuzzy substring matching by default #4537
155ac37 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 15, 2019
@akosyakov
[file-search] handle cancellation properly to avoid race conditions #…
037aac5 
…4537

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 15, 2019
@akosyakov
[file-search] match against relative paths (not absolute) #4537
79ded6c 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Mar 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application commands issues related to application commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

quick palette fixes eclipse-theia/theia
2 participants
@AlexTugarev @akosyakov