-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[electron] As a developer I want to build a bundled electron application from the source #4874
Comments
Closes #4874. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #4874. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Depends on: #6712 |
Is it not more because So even if we tried to bundle the example app by pointing to the root If so, is it better to have an |
I got tired of hacking and guessing and opened an upstream ticket: electron-userland/electron-builder#4516 |
Currently, we have a kind of working solution outside of the repository: https://github.com/theia-ide/theia-apps/tree/master/theia-electron.
For historical reasons, we had to move the electron bundling outside of the repository, because the
electron-builder
could not follow symlinks. In other words, and it is an oversimplification, thepackage.json
of the electron application wasn't next to thenode_modules
folder where the real dependencies were:examples/electron/package.json
andnode_modules
.Make sure we can bundle and not just build an electron application from the source.
Otherwise, we have to merge changes to the
master
, then verify it in the bundled electron application. We could try it withdeferSymlinks
.The text was updated successfully, but these errors were encountered: