Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[electron] As a developer I want to build a bundled electron application from the source #4874

Open
kittaakos opened this issue Apr 11, 2019 · 3 comments
Labels
electron issues related to the electron target

Comments

@kittaakos
Copy link
Contributor

Currently, we have a kind of working solution outside of the repository: https://github.com/theia-ide/theia-apps/tree/master/theia-electron.

For historical reasons, we had to move the electron bundling outside of the repository, because the electron-builder could not follow symlinks. In other words, and it is an oversimplification, the package.json of the electron application wasn't next to the node_modules folder where the real dependencies were: examples/electron/package.json and node_modules.

Make sure we can bundle and not just build an electron application from the source.
Otherwise, we have to merge changes to the master, then verify it in the bundled electron application. We could try it with deferSymlinks.

@kittaakos kittaakos added the electron issues related to the electron target label Apr 11, 2019
kittaakos pushed a commit that referenced this issue Apr 12, 2019
Closes #4874.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Dec 6, 2019
Closes #4874.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos
Copy link
Contributor Author

Depends on: #6712

@paul-marechal
Copy link
Member

For historical reasons, we had to move the electron bundling outside of the repository, because the electron-builder could not follow symlinks.

Is it not more because electron-builder didn't know what to bundle, since the dependencies for the Electron application were hoisted to the mono-repo root with all other dependencies?

So even if we tried to bundle the example app by pointing to the root node_modules, it would bundle dev and unrelated dependencies?

If so, is it better to have an @theia/example-bundled electron app which would not be part of the yarn + lerna workspaces? The package.json of this app would refer to the other extensions locally using paths as version constraints? This way would ensure that yarn doesn't mix deps from the other packages with the deps for this specific application. Is this worth a shot?

@kittaakos
Copy link
Contributor Author

I got tired of hacking and guessing and opened an upstream ticket: electron-userland/electron-builder#4516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants