Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "DeclarationProvider" API #5213

Closed
tsmaeder opened this issue May 22, 2019 · 2 comments · Fixed by #6173
Closed

Implement "DeclarationProvider" API #5213

tsmaeder opened this issue May 22, 2019 · 2 comments · Fixed by #6173
Assignees
@vrubezhny @AlexTugarev
Labels
Team: Che-Languages issues regarding the che-languages team vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

Add an implementation of the API "registerDeclarationProvider" analogous to the "registerDefinitionProvider" API.

I
@tsmaeder tsmaeder added vscode issues related to VSCode compatibility Team: Che-Languages issues regarding the che-languages team labels May 22, 2019
@tsmaeder tsmaeder changed the title Implement "DeclarationProvider" API VS Code API Implement "DeclarationProvider" API May 22, 2019
@tsmaeder tsmaeder mentioned this issue May 22, 2019
Closed
26 tasks
@tsmaeder tsmaeder mentioned this issue Jun 11, 2019
Closed
27 tasks
@vrubezhny
Copy link
Contributor

As monaco.d.ts v.0.14.6 doesn't haveDeclarationProviderinterface exported. we cannot implement $registerDeclarationProvider(handle: number, selector: SerializedDocumentFilter[]): void in LanguagesMainImpl... Here we're blocked by @typefox/monaco-editor-core update which is planned by the end of July, see: https://spectrum.chat/theia/dev/update-monaco~d0b4d5a5-e688-4f0f-a54f-e2d2b24525ee

@AlexTugarev AlexTugarev self-assigned this Sep 12, 2019
@AlexTugarev
Copy link
Contributor

@vrubezhny, I'm about to create a PR for this. Python extension seem to be broken without this. I'll be happy to add you to reviewers 🙏

@AlexTugarev AlexTugarev mentioned this issue Sep 12, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrubezhny vrubezhny

@AlexTugarev AlexTugarev

Labels
Team: Che-Languages issues regarding the che-languages team vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[plugin] Implement registerDeclarationProvider eclipse-theia/theia
3 participants
@vrubezhny @AlexTugarev @tsmaeder