Enter is not working in editor

[RomanNikitenko]

Description

Enter is not working in editor

Reproduction Steps

Open some file and try to use Enter button.

OS and Theia version:
Ubuntu 18.04. Chrome.
0953ba7

[azatsarynnyy]

reproduced on my side, also

[vince-fugnitto]

I believe it's caused during #5865

[akosyakov]

@vince-fugnitto Could you try before 0953ba7 please to confirm?

[akosyakov]

@vince-fugnitto you are right, looking at addKeyListener: https://github.com/theia-ide/theia/blob/b40a8d54380524dd1a8b05992ebf540b68806e92/packages/core/src/browser/widgets/widget.ts#L206-L209

We should add return statements, i.e.

    protected handleEscape(event: KeyboardEvent): boolean | void {
        const dialog = this.currentDialog;
        if (dialog) {
            return dialog['handleEscape'](event);
        }
        return false;
    }

    protected handleEnter(event: KeyboardEvent): boolean | void {
        const dialog = this.currentDialog;
        if (dialog) {
            return dialog['handleEnter'](event);
        }
        return false;
    }

Could someone do a PR please?

[akosyakov]

Also here: f48398e

we should do return false after if

[vince-fugnitto]

@vince-fugnitto Could you try before 0953ba7 please to confirm?

Yes I tried earlier, both 0953ba7 and HEAD~1 and the problem was in 0953ba7