Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support "showOutput" flag in task config #5974

Closed
elaihau opened this issue Aug 17, 2019 · 2 comments
Closed

support "showOutput" flag in task config #5974

elaihau opened this issue Aug 17, 2019 · 2 comments
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@elaihau
Copy link
Contributor

elaihau commented Aug 17, 2019

Description

In VS Code there is a showOutput flag we can use to toggle if task output should show up in the terminal
https://stackoverflow.com/a/38723286

In Theia we should implement the same thing to achieve the same user experiences.

Reproduction Steps

Run any task in Theia. The task output shows up in the terminal.

OS and Theia version:

Ubuntu 18.04. master branch as of Aug 16 2019. Example browser

@elaihau elaihau added the tasks issues related to the task system label Aug 17, 2019
@westbury
Copy link
Contributor

This is related to #5597 . That PR exposes output on the frontend but does not dictate where it goes, so it can go to, for example, a progress monitor, output channel, or a problem marker generator. Remember that Theia is extendable whereas VS Code is not, so while a toggle may be appropriate for VS Code, the ability to rebind API is more useful for Theia extenders.

@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Aug 18, 2019
@vince-fugnitto
Copy link
Member

The showOuput flag has been deprecated for a while now (since 1.14 in VS Code) and was replaced by the reveal property. I believe we can safely close the issue as reveal provides even more options for end-users.

definitions.showOutputType.deprecationMessage = nls.localize(
	'JsonSchema.tasks.showOputput.deprecated',
	'The property showOutput is deprecated. Use the reveal property inside the presentation property instead. See also the 1.14 release notes.'
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

4 participants