Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins are not loaded when theia is started without internet access #6055

Closed
tom-shan opened this issue Aug 28, 2019 · 4 comments · Fixed by #6057
Closed

plugins are not loaded when theia is started without internet access #6055

tom-shan opened this issue Aug 28, 2019 · 4 comments · Fixed by #6057
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system
Milestone
0.10.x

Comments

@tom-shan
Copy link
Contributor

Description

All the vscode plugins can not be loaded when my host machine has no Internat access.

we have two local vscode extensions which we downloaded from vscode marketplace:
1 vscjava.vscode-java-dependency
2 redhat.java

It should be noted that the vscjava.vscode-java-dependency extension depends on redhat.java(see https://github.com/microsoft/vscode-java-dependency/blob/master/package.json#L165).
When I start theia, theia plugin system will still try to download redhat.java from vscode marketplace. If my host has no Internat access, then all the plugins can not be loaded.

Reproduction Steps

OS and Theia version:
centos 7
theia 6c4fa9c7
Diagnostics:

related to #5379 and #6038
@akosyakov akosyakov added this to the 0.10.x milestone Aug 28, 2019
@akosyakov akosyakov added bug bugs found in the application plug-in system issues related to the plug-in system labels Aug 28, 2019
@akosyakov
Copy link
Member

akosyakov commented Aug 28, 2019 •
edited
Loading

It is a regression caused by auto pulling extension dependencies. We should handle it gracefully and does not fail the whole deployment if one VS Code extension cannot be downloaded. cc @JPinkney

@tom-shan I wonder how do you provide redhat.java then? If you don't do it then vscjava.vscode-java-dependency won't work properly either, no? Could you share a bit more info about your settings, i.e. plugins args or env variables?

@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Aug 28, 2019
@akosyakov
Copy link
Member

@tom-shan Also If you can please help fixing it!

tom-shan added a commit to tom-shan/theia that referenced this issue Aug 28, 2019
@tom-shan
fix plugins are not loaded when staring theia without internet access
4748d14 
fix eclipse-theia#6055
If all the vscode entensions dependencies(listed in the extensionDependencies field of vscode extension)
are already downloaded to local directory before staring theia, then there is no need to download them
from the remote(vscode marketplace) during the theia starting process.

Signed-off-by: tom-shan <swt0008411@163.com>
@tom-shan tom-shan mentioned this issue Aug 28, 2019
Closed
1 task
@tom-shan
Copy link
Contributor Author

@tom-shan I wonder how do you provide redhat.java then? If you don't do it then vscjava.vscode-java-dependency won't work properly either, no? Could you share a bit more info about your settings, i.e. plugins args or env variables?

No, vscjava.vscode-java-dependency won't work properly.
I just download vscjava.vscode-java-dependency from vscode markeplace and copy it to plugins directory.

@tom-shan Also If you can please help fixing it!

Sure, please have a review.

@tom-shan
Copy link
Contributor Author

tom-shan commented Aug 28, 2019 •
edited
Loading

In my local repo, I just comment these 3 lines.

akosyakov added a commit that referenced this issue Aug 28, 2019
@akosyakov
fix #6055: tolerate missing internet access while deploying plugins
ab2d110 
- check whether a plugin is already to be deployed by an id
- fix to use canonical plugin ids to resolve and activate plugins
- make sure that dependencies only resolved after listed plugin entries
- don't fail the entire deployment if a resolution of a single plugin entry failed

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Aug 28, 2019
Merged
1 task
akosyakov added a commit that referenced this issue Aug 28, 2019
@akosyakov
fix #6055: tolerate missing internet access while deploying plugins
248fa21 
- check whether a plugin is already to be deployed by an id
- fix to use canonical plugin ids to resolve and activate plugins
- make sure that dependencies only resolved after listed plugin entries
- don't fail the entire deployment if a resolution of a single plugin entry failed

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@vince-fugnitto vince-fugnitto changed the title plugins are not loaded when theia is started without Internat access plugins are not loaded when theia is started without internet access Aug 28, 2019
akosyakov added a commit that referenced this issue Aug 29, 2019
@akosyakov
fix #6055: tolerate missing internet access while deploying plugins
1a3048d 
- check whether a plugin is already to be deployed by an id
- fix to use canonical plugin ids to resolve and activate plugins
- make sure that dependencies only resolved after listed plugin entries
- don't fail the entire deployment if a resolution of a single plugin entry failed

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system
Projects
None yet
Milestone
0.10.x
2 participants
@akosyakov @tom-shan