Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode][webview]plugin can't open webview after close #6288

Closed
502647092 opened this issue Sep 28, 2019 · 2 comments · Fixed by #6326
Closed

[vscode][webview]plugin can't open webview after close #6288

502647092 opened this issue Sep 28, 2019 · 2 comments · Fixed by #6326
Assignees
@akosyakov
Labels
bug bugs found in the application webviews issues related to webviews

Comments

@502647092
Copy link
Contributor

502647092 commented Sep 28, 2019 •
edited
Loading

Description

after close plugin webview
plugin can't open it again

temp

Reproduction Steps

  • ext install vscode:extension/humao.rest-client
  • create simple http file
GET https://www.google.com
  • send request
  • close webivew
  • send request again
  • webview can't show

OS and Theia version:
latest theia
window10
chrome 77

Diagnostics:
@502647092
Copy link
Contributor Author

@akosyakov

@akosyakov akosyakov added bug bugs found in the application webviews issues related to webviews help wanted issues meant to be picked up, require help labels Sep 29, 2019
@akosyakov
Copy link
Member

It could be a regression after fixing handling reconnections by the plugin system. I'm not available till Tuesday. If someone can have a look before it would be helpful.

@akosyakov akosyakov self-assigned this Oct 4, 2019
@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Oct 4, 2019
akosyakov added a commit that referenced this issue Oct 4, 2019
@akosyakov
[plugin] fix #6288: dispose webview by a handle, not a widget id
dec5f2d 
Otherwise the webview is not disposed in the plugin host process.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Oct 4, 2019
Merged
1 task
akosyakov added a commit that referenced this issue Oct 4, 2019
@akosyakov
[plugin] fix #6288: dispose webview by a handle, not a widget id
5e8c3d8 
Otherwise the webview is not disposed in the plugin host process.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[plugin] fix eclipse-theia#6288: dispose webview by a handle, not a w…
5cc5e76 
…idget id

Otherwise the webview is not disposed in the plugin host process.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application webviews issues related to webviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[plugin] dispose webview by a handle, not a widget id eclipse-theia/theia
2 participants
@akosyakov @502647092