Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin] initial document deltas are missing sometimes #6319

Closed
akosyakov opened this issue Oct 3, 2019 · 0 comments · Fixed by #6321
Closed

[plugin] initial document deltas are missing sometimes #6319

akosyakov opened this issue Oct 3, 2019 · 0 comments · Fixed by #6321
Assignees
@akosyakov
Labels
bug bugs found in the application vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Oct 3, 2019 •
edited
Loading

It is reproducible with go vscode extension:

  • open a document
  • enable the LS tracing via preferences, i.e. golsp.server.trace to verbose
  • reload the page
  • see that changes to previously opened document is not sent to the LS
@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility labels Oct 3, 2019
@akosyakov akosyakov self-assigned this Oct 3, 2019
akosyakov added a commit that referenced this issue Oct 3, 2019
@akosyakov
[plugin] fix #6319: start document listening when all clients are ready
3b4690d 
Otherwise events for already opened document can be missed.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Oct 3, 2019
Merged
1 task
akosyakov added a commit that referenced this issue Oct 4, 2019
@akosyakov
[plugin] fix #6319: start document listening when all clients are ready
0bb4c49 
Otherwise events for already opened document can be missed.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[plugin] fix eclipse-theia#6319: start document listening when all cl…
83a623d 
…ients are ready

Otherwise events for already opened document can be missed.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[plugin] start document listening when all clients are ready eclipse-theia/theia
1 participant
@akosyakov