Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question][label-provider] Inconsistency between WS root and other URIs? #6549

Open
kittaakos opened this issue Nov 14, 2019 · 3 comments
Open
Labels
question user / developer questions

Comments

@kittaakos
Copy link
Contributor

Description

Why does the label provider provide a full FS path when the input is the workspace URI and workspace relative paths when the URI argument points to any file inside the workspace. I found this inconsistency here: #6545 (comment) It smells like a workaround for something.

Reproduction Steps

OS and Theia version:

Diagnostics:

@kittaakos kittaakos added the question user / developer questions label Nov 14, 2019
@akosyakov
Copy link
Member

An idea was that:

  • in multi-root workspaces the same file can belong to multiple roots, so we show the absolute path.
  • If there is only one root, we show the relative path, since it is clear from the context.

If it is not like that then it is a bug.

@kittaakos
Copy link
Contributor Author

If it is not like that then it is a bug.

I wish I could change the multi-root workspace preference and verify it 😕 #6349

@vince-fugnitto
Copy link
Member

If it is not like that then it is a bug.

I wish I could change the multi-root workspace preference and verify it 😕 #6349

Not the best, but I guess a possible workaround is to update the preference outside of Theia 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question user / developer questions
Projects
None yet
Development

No branches or pull requests

3 participants