Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theming] unable to successfully display custom file icons in electron #6834

Closed
vince-fugnitto opened this issue Jan 6, 2020 · 2 comments
Closed

[theming] unable to successfully display custom file icons in electron #6834

vince-fugnitto opened this issue Jan 6, 2020 · 2 comments
Labels
bug bugs found in the application electron issues related to the electron target help wanted issues meant to be picked up, require help theming issues related to theming

Comments

@vince-fugnitto
Copy link
Member

Description

As part of #6475, it is now possible to change the application's file icon theme.
However, when running in Electron the icons are not properly displayed:

Default Icon (Theia):

image

Seti Icon (Theia):

image

For reference, the browser version works correctly:

image

Steps to Reproduce:

  1. install https://registry.npmjs.org/@theia/vscode-builtin-vscode-theme-seti/-/vscode-builtin-vscode-theme-seti-0.3.0-next.2111655b67.tgz (Seti Icon Theme) as a plugin
  2. start the electron application
  3. change file icon theme to Seti using the command Preferences: File Icon Theme
@vince-fugnitto vince-fugnitto added bug bugs found in the application electron issues related to the electron target theming issues related to theming labels Jan 6, 2020
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Jan 6, 2020
@vince-fugnitto vince-fugnitto mentioned this issue Jan 31, 2020
Open
@lmcbout lmcbout mentioned this issue Jan 31, 2020
Closed
@Johannes-B-stock Johannes-B-stock mentioned this issue Mar 11, 2020
Closed
1 task
@owlJaeger
Copy link
Contributor

owlJaeger commented Apr 10, 2020 •
edited
Loading

My testing resulted in finding out that the seti.woff font-file will not be loaded as a @font-face and thus the icons won't be shown. I've already found a workaround but I am looking for a permanent solution.

If someone really needs these icons to work in his electron app, one possible workaround is to add this to the <head></head> section of the lib/index.html file:

<style>
@font-face {
  font-family: 'seti';
  src: url("file:///<path to your project>/plugins/vscode-builtin-icon-theme-seti/extension/icons/seti.woff") format('woff');
  font-weight: normal;
  font-style: normal;
}
</style>

@owlJaeger owlJaeger mentioned this issue Apr 15, 2020
Merged
1 task
@vince-fugnitto
Copy link
Member Author

Closed by #7583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application electron issues related to the electron target help wanted issues meant to be picked up, require help theming issues related to theming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @vince-fugnitto @owlJaeger