Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submenu icon #6891

Closed
Hanksha opened this issue Jan 16, 2020 · 4 comments
Closed

Submenu icon #6891

Hanksha opened this issue Jan 16, 2020 · 4 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help menus issues related to the menu

Comments

@Hanksha
Copy link
Contributor

Hanksha commented Jan 16, 2020 •
edited
Loading

Add possibility to set an icon for a submenu. Current MenuModelRegistry.registerSubmenu only accept a label.

For example:
Screen Shot 2020-01-16 at 9 13 35 AM
I'd like the Add submenu to have a + green icon.
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help menus issues related to the menu labels Jan 16, 2020
@akosyakov
Copy link
Member

@Hanksha I don't think active committers will work on it any time soon. An idea will be to add another argument to registerSubmenu, something like SubmenuOptions, which should be optional and it can have different properties in it. Feel free to work on it and send a PR.

@Hanksha
Copy link
Contributor Author

Hanksha commented Jan 16, 2020

@akosyakov Alright, I will do when I get some free time.

@Hanksha
Copy link
Contributor Author

Hanksha commented Feb 6, 2020 •
edited
Loading

Got something working.
Screen Shot 2020-02-06 at 10 24 58 AM
Screen Shot 2020-02-06 at 10 32 57 AM

Hanksha added a commit to Hanksha/theia that referenced this issue Feb 6, 2020
@Hanksha
[eclipse-theia#6891] Add support for setting the icon of a submenu
cc4fcd2 
Signed-off-by: Vivien Jovet <vivien.jovet@gmail.com>
Hanksha added a commit to Hanksha/theia that referenced this issue Feb 7, 2020
@Hanksha
[eclipse-theia#6891] Add support for setting the icon of a submenuSig…
7e47fd3 
…ned-off-by: Vivien Jovet <vivien.jovet@gmail.com>
Hanksha added a commit to Hanksha/theia that referenced this issue Feb 7, 2020
@Hanksha
[eclipse-theia#6891] Add support for setting the icon of a submenu
04eac17 
Signed-off-by: Vivien Jovet <vivien.jovet@gmail.com>
akosyakov pushed a commit that referenced this issue Feb 7, 2020
@Hanksha @akosyakov
[#6891] Add support for setting the icon of a submenu
d5f3262 
Signed-off-by: Vivien Jovet <vivien.jovet@gmail.com>
@vince-fugnitto
Copy link
Member

Closed by #7091

akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@Hanksha @akosyakov
[eclipse-theia#6891] Add support for setting the icon of a submenu
425bb47 
Signed-off-by: Vivien Jovet <vivien.jovet@gmail.com>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
@Hanksha
[eclipse-theia#6891] Add support for setting the icon of a submenu
ae275d3 
Signed-off-by: Vivien Jovet <vivien.jovet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help menus issues related to the menu
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @Hanksha @vince-fugnitto