Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theme][Markdown] Text of shell code blocks with light theme are rendered in the same color as the background in Markdown files in text editor #6907

Closed
corneliusludmann opened this issue Jan 17, 2020 · 3 comments · Fixed by #6966
Assignees
Labels
bug bugs found in the application markdown issues related to markdown plug-in system issues related to the plug-in system textmate issues related to the textmate grammars vscode issues related to VSCode compatibility

Comments

@corneliusludmann
Copy link
Contributor

Description

The text of shell code blocks in Markdown files are rendered white (same as background) in light theme in the text editor (NOT the Markdown preview).

Reproduction Steps

Create a Markdown file (e.g. README.md) and add the following content:

Build:
```shell
$ yarn && yarn plugins:update && yarn build
```

In the dark theme is looks like this:
image

However in the light theme, most of the text is missing (same color as the background):
image

OS and Theia version:

  • Theia next (browser)
@vince-fugnitto vince-fugnitto added textmate issues related to the textmate grammars markdown issues related to markdown labels Jan 18, 2020
@akosyakov akosyakov added help wanted issues meant to be picked up, require help bug bugs found in the application labels Jan 18, 2020
@akosyakov akosyakov self-assigned this Jan 18, 2020
@corneliusludmann
Copy link
Contributor Author

It's also in TypeScript:

image

image

(The dot before size is missing in the light theme.)

@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Jan 22, 2020
@akosyakov
Copy link
Member

I can reproduce markdown issue, but not with typescript.

@akosyakov
Copy link
Member

It happens because shell script is registered after markdown language, so markdown tokenizer does not recognize it as an embedded language and does not apply proper coloring. We need to compute id of an embedded language lazily or something like that.

@akosyakov akosyakov added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Jan 27, 2020
akosyakov added a commit that referenced this issue Jan 27, 2020
…istered

otherwise not yet registered languages are not considered as embedded languages for grammars

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 27, 2020
to fix coloring issues, see #6907

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 28, 2020
…istered

otherwise not yet registered languages are not considered as embedded languages for grammars

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 28, 2020
…istered

otherwise not yet registered languages are not considered as embedded languages for grammars

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 28, 2020
…istered

otherwise not yet registered languages are not considered as embedded languages for grammars

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 28, 2020
…istered

otherwise not yet registered languages are not considered as embedded languages for grammars

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
…uages are registered

otherwise not yet registered languages are not considered as embedded languages for grammars

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
…uages are registered

otherwise not yet registered languages are not considered as embedded languages for grammars

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application markdown issues related to markdown plug-in system issues related to the plug-in system textmate issues related to the textmate grammars vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants