Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support scm/resourceFolder/context menu contribution #6915

Closed
akosyakov opened this issue Jan 20, 2020 · 3 comments
Closed

support scm/resourceFolder/context menu contribution #6915

akosyakov opened this issue Jan 20, 2020 · 3 comments
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

No description provided.

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves git issues related to git vscode issues related to VSCode compatibility labels Jan 20, 2020
@westbury
Copy link
Contributor

It is not possible to support scm/resourceFolder/context unless there is a folder resource change UI element somewhere on which to put the context menu. So this issue does require #7505 . As it happens, that PR does use scm/resourceFolder/context to get the menu for folders, so it does fix this issue.

However it would be nice to get https://open-vsx.org/api/vscode/git/1.39.1/file/vscode.git-1.39.1.vsix working first. That version, unlike vscode-git-1.3.0.1, makes contributions to this location. It would be nice to be able to test with this builtin version before closing this issue.

@akosyakov
Copy link
Member Author

I will try to look at #6921 next week. I've tested it against 1.39.1.

@westbury
Copy link
Contributor

westbury commented Jun 4, 2020

I've now been able to test with vscode.git-1.39.1.vsix. The scm/resourceFolder/context menu items show correctly when switching Source Control view to tree mode and right-clicking on a folder. I'm therefore closing this.

@westbury westbury closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

2 participants