-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Unknown actor YourServiceName
when refreshing the browser window
#7176
Comments
Unknwon actor is a dup of #5839? |
Ok, looking into it. Initial errors are not related they are because of missing VS Code apis and too many configuration listeners from VS Code extensions. Unfortunately cannot reproduce following to given steps, but will try something else. |
I can reproduce it with debugging Theia Browser Backend:
It is triggered by disposing the plugin host process while It's processing requests from Theia, so then there are some unfinished communications. |
I think it comes from here: theia/packages/plugin-ext/src/hosted/node/hosted-plugin-process.ts Lines 96 to 112 in 1ca3ec3
The frontend is already gone, but to shutdown the plugin host process we create a new RPC which does not have any frontend services, so all requests from the plugin host process caused by deactivation are failing. I wonder what should be the proper way to handle them. Should we ignore messages produced by the plugin host process, i.e. |
I assume this code is to handle abrupt shutdown of a client, like a browser crashed. We should consider the page reload as a normal situation and make sure that frontend context is not gone while the plugin process is not shutdown completely. In abrupt situations I'm not sure whether we should try to be smart and deactivate plugins, since it is not possible already. Probably it would be better just kill the process in such cases. |
…ction Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
…ction Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
…ction Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
…out rpc connection Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Description
Happened when verifying #5167.
I can see a lot of
Unknown actor ServiceName
error in the console after refreshing the browser.Steps to reproduce:
.node_modules/@theia/api-tests/src/browser-utils.spec.js
in an editor. Note, it's fromnode_modules
.Close the editor and refresh the browser window:
Note, I have truncated the stack trace 👆, it was more than 2k lines. I can consistently reproduce it.
Reproduction Steps
OS and Theia version:
Diagnostics:
The text was updated successfully, but these errors were encountered: