Elm Extension won't start because it requires VSCode 1.42

[JesterOrNot]

Description

Language server fails to start due to an outdated version of VSCode

Reproduction Steps

Open https://gitpod.io/#https://github.com/jesterornot/gitpod-elm/tree/bug
The relevant extension is https://marketplace.visualstudio.com/items?itemName=Elmtooling.elm-ls-vscode

OS and Theia version:
Gitpod

Diagnostics:

The language client requires VS Code version ^1.42.0 but received version 1.41.1

[vince-fugnitto]

@JesterOrNot you can specify a VSCODE_API_VERSION when starting the application if you'd like, else I'd suggest using an older version of the elm extension. We are still working towards supporting newer versions of the API (and ultimately extensions). (related #6804)

For the moment I think we can hold-off creating issues for each extension we encounter which requires the newer API as it will become noisy and instead work towards supporting the new API.
In the meantime it is acceptable to use older versions of extensions (it is actually what we do with the builtins).

[akosyakov]

We should bump up VSCODE_API_VERSION. It's again vscode-languageclient defaults to 1.42. Any extension which is using this version regardless whether it actually uses unsupported by us features won't work.

After that we should test elm for unsupported API.

We are still working towards supporting newer versions of the API (and ultimately extensions). (related #6804)

that's not necessary unrelated, monaco-languageclient upgrade is needed only for language support via Theia extensions

[akosyakov]

Yes, just checked that they are using progress enhancements from new vscode-languageclient: elm-tooling/elm-language-client-vscode@b6516fb#diff-bc3c0f2fe3aca9ddbe96347ffb00641e

It is already supported by us.

[akosyakov]

@JesterOrNot it can be bumped up here:

theia/packages/plugin-ext-vscode/src/node/plugin-vscode-init.ts

Line 22 in 764b740

export const VSCODE_DEFAULT_API_VERSION = '1.41.1';

[JesterOrNot]

On it!

[dsseng]

Vetur is also affected, v0.24.0 doesn't work without VS Code API v1.42.x

[akosyakov]

@sh7dm Could you send a PR bumping up the version and check whether vetur works with it?

[dsseng]

Of course 🤠 !

[dsseng]

@akosyakov that works, I'll submit a PR.