Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM View Should Allow Multi-Select #7659

Closed
tsmaeder opened this issue Apr 23, 2020 · 4 comments · Fixed by #7900
Closed

SCM View Should Allow Multi-Select #7659

tsmaeder opened this issue Apr 23, 2020 · 4 comments · Fixed by #7900
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves scm issues related to the source control manager ui/ux issues related to user interface / user experience

Comments

@tsmaeder
Copy link
Contributor

One can only select single entries in the "Source Control" view. This is annoying when trying to stage multiple changes in git, for example.

To reproduce:

  1. Make changes in multiple files in a git project in your workspace
  2. Go to the "Source Control" view
  3. Observe: you see the changed files under "Changes"
  4. Shift-Click or Ctrl-Click multiple files in the view
  5. Observe: as soon as you click a second file, the selection on the first goes away

Multi-select works in this view in VS Code (and it's mighty useful, I dare say)

@tsmaeder tsmaeder added scm issues related to the source control manager enhancement issues that are enhancements to current functionality - nice to haves OS/Windows issues related to the Windows OS ui/ux issues related to user interface / user experience labels Apr 23, 2020
@vince-fugnitto
Copy link
Member

@tsmaeder is it fine to close the original, the issue is a duplicate of #1318

@tsmaeder
Copy link
Contributor Author

🤷 I was looking for "scm" issues. I would suspect this is not git specific?

@vince-fugnitto
Copy link
Member

🤷 I was looking for "scm" issues. I would suspect this is not git specific?

I believe it is the same problem, the original was named git since we had no notion of scm before. I'll close the original in favor of this one as it is newer and more up to date :)

@kittaakos kittaakos removed the OS/Windows issues related to the Windows OS label Apr 23, 2020
@westbury
Copy link
Contributor

This should be easy once #7505 is merged. That PR re-writes the source control view to use tree-widget, so we can use the same selection code. Also that PR adds support for an array of ScmResource in the context menu args (previously just a single ScmResource allowed), and downstream dugite API adjusted to accept multiples. This was actually done to support actions on folders. As I already know the changes required here, I'll prepare the PR and submit it once #7505 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves scm issues related to the source control manager ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants