Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open deleted file in GIT SCM causes errors #8106

Closed
datou0412 opened this issue Jun 29, 2020 · 1 comment · Fixed by #8107
Closed

Open deleted file in GIT SCM causes errors #8106

datou0412 opened this issue Jun 29, 2020 · 1 comment · Fixed by #8107
Labels
bug bugs found in the application git issues related to git help wanted issues meant to be picked up, require help

Comments

@datou0412
Copy link
Contributor

Bug Description:

Open deleted file in GIT SCM causes errors

Steps to Reproduce:

  1. delete any file
  2. open it in scm

UnStaged Case
image

Staged Case
image

VS Code Case

UnStaged Case
image

Staged Case
image

Additional Information

  • Operating System: MacOS Mojave 10.14.6
  • Theia Version: 1.3.0
@akosyakov
Copy link
Member

We should not use file scheme for deleted files. It won't be able to resolve anything from the disk.

@akosyakov akosyakov added bug bugs found in the application git issues related to git help wanted issues meant to be picked up, require help labels Jun 29, 2020
@datou0412 datou0412 mentioned this issue Jun 29, 2020
Merged
1 task
westbury pushed a commit that referenced this issue Jul 13, 2020
@datou0412 @westbury
fix #8106:fix open deleted file in git scm errors
a1ea230 
Signed-off-by: 二凢 <dingyu.wdy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application git issues related to git help wanted issues meant to be picked up, require help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #8106:fix open deleted file in git scm errors
2 participants
@akosyakov @datou0412