Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing the previously opened WS roots should be application specific #811

Closed
kittaakos opened this issue Nov 10, 2017 · 4 comments
Closed

Comments

@kittaakos
Copy link
Contributor

This task is a follow-up of #809.

If one uses multiple Theia-based applications, one application might override the WS root settings of another application in the user's home directory.

See also: #809 (comment)

@hexa00
Copy link

hexa00 commented Nov 10, 2017

Actually should we juste have a .application name directory instead of a .theia ?

@kittaakos
Copy link
Contributor Author

It is up to the implementation. If we go with the application name folder approach, we have to know the name of the application at runtime. Perhaps, we would need an app specific binding which is not the best because we would force each Theia adapter to customize that binding.

I do not know the proper solution yet. I thought we could distinguish based on the path of the underlying process. That should be unique per application. One needs to define this before implementing this task.

@hexa00
Copy link

hexa00 commented Nov 10, 2017

I vote for a binding since I don't want to give to much meaning to the path.

This binding was proposed before in #687 so it may come up again.

@kittaakos
Copy link
Contributor Author

Resolved via #7214.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants