Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing issues when starting plugin hosts #8429

Open
tsmaeder opened this issue Aug 25, 2020 · 0 comments
Open

Timing issues when starting plugin hosts #8429

tsmaeder opened this issue Aug 25, 2020 · 0 comments
Labels
bug bugs found in the application plug-in system issues related to the plug-in system

Comments

@tsmaeder
Copy link
Contributor

Bug Description:

While investigating eclipse-che/che#16502, I noticed that some messages from plugins get lost when starting up: connections to plugin hosts are started as soon as the the connection module for a Theia front end is constructed on the back end. At this time, the connection back to the front end may not be set up yet. When this is the case, messages from plugin hosts can be silently ignored, for example https://github.com/eclipse-theia/theia/blob/master/packages/plugin-ext/src/hosted/node/hosted-plugin-process.ts#L156
In particular, "setClient" is called after connection to the plugin host: since the plugin host starts operating upon connection, it may send message that are lost.

Steps to Reproduce:

There is really no reproducible case for this: however, we seem to see some intermittent issues in Che, where startup of plugin hosts are slower (and we have more of them).

Additional Information

  • Operating System: n/a
  • Theia Version: 1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system
Projects
None yet
Development

No branches or pull requests

1 participant