Fixed Git history to show the correct date and fixed some typos (#1754) #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CIs complained about a missing semicolon. I could not spot it in your change; so I have just restarted the builds. Let's see. |
akosyakov
reviewed
Apr 26, 2018
| @@ -107,10 +107,12 @@ export class GitHistoryWidget extends GitNavigableListWidget<GitHistoryListNode> | |||
| const commits: GitCommitNode[] = []; | |||
| for (const commit of changes) { | |||
| const fileChangeNodes: GitFileChangeNode[] = []; | |||
| const avatarUrl = await this.avartarService.getAvatar(commit.author.email); | |||
| const avatarUrl = await this.avatarService.getAvatar(commit.author.email); | |||
| const authorDate = new Date(commit.author.timestamp): | |||
There was a problem hiding this comment.
Ohh, it was too early. Thanks!
|
Wow, I apologized I missed that. I fixed the colon. |
|
@AlexErling, could you please squash your commits into one? |
Signed-off-by: Alex Erling <alex.erling@gmail.com> Fixed semi colon error. Signed-off-by: Alex Erling <alex.erling@gmail.com>
|
@kittaakos I squashed them. |
kittaakos
reviewed
Jun 11, 2018
| const avatarUrl = await this.avartarService.getAvatar(commit.author.email); | ||
| const avatarUrl = await this.avatarService.getAvatar(commit.author.email); | ||
| const authorDate = new Date(commit.author.timestamp); | ||
| authorDate.setUTCSeconds(commit.author.timestamp); |
There was a problem hiding this comment.
I have reviewed the code and my recommendation was incorrect. We should do:
const authorDate = new Date(commit.author.timestamp * 1000);instead of:
const authorDate = new Date(commit.author.timestamp);
authorDate.setUTCSeconds(commit.author.timestamp);Could you please make an update, @AlexErling?
|
Closing in favor of #3410. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Erling alex.erling@gmail.com
I was having issues so I just started over and made a new pull request.
Here are the changes!
Closes issue #1754