Fix 'Close Workspace' #3386
Merged
Fix 'Close Workspace' #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2662 - Fixed issue with the command `Close Workspace` which did not work on all browsers - Since the function `setMostRecentlyUsedWorkspace` returns a Promise, it was necessary to `await` until the data is saved in `recentWorkspace.json` before reloading Theia Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
fix-close-workspace
branch
from
72cc8d0
to
3cdabbc
Compare
simark
reviewed
Nov 3, 2018
simark
approved these changes
Nov 3, 2018
elaihau
reviewed
Nov 3, 2018
| this._workspace = undefined; | ||
| this._roots.length = 0; | ||
|
|
||
| this.server.setMostRecentlyUsedWorkspace(''); |
There was a problem hiding this comment.
Maybe we could talk on Monday in person. Like Simon, I don't really understand the difference.
There was a problem hiding this comment.
I had to make sure to await the call this.server.setMostRecentlyUsedWorkspace('') in order for the backend to properly finish updating before Theia can reload. What I noticed in Firefox for example is that the update never resolves so when Theia reloads it reloads with the workspace that was opened before the Close Workspace was called.
lmcbout
approved these changes
Nov 5, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2662
Close Workspacewhich did not work on all browserssetMostRecentlyUsedWorkspacereturns a Promise, it was necessary toawaituntil the data is saved inrecentWorkspace.jsonbefore reloading TheiaSigned-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com