Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Open Recent Workspace' command and menu item #3427

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Nov 7, 2018

Fixes #3421
Fixes #3428

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good to me.

@vince-fugnitto
Copy link
Member Author

@akosyakov are you fine with this solution?

Fixes #3421

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@kittaakos
Copy link
Contributor

I will try the changes locally, and if it works, I'll merge the PR...

@kittaakos kittaakos self-requested a review November 8, 2018 07:03
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! I have tried both examples on Windows and OS X; it works.

@kittaakos kittaakos merged commit 5928c2d into master Nov 8, 2018
@kittaakos
Copy link
Contributor

@vince-fugnitto, please clean up the branch if you do not need it. I did not want to delete it after the merge.

@vince-fugnitto
Copy link
Member Author

thanks @kittaakos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants