GH-5100: Update the menu if the frontend is ready.

[kittaakos]

Closes #5100.

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

• Forcefully sets the application menu once the frontend application is ready.

How to test

• See details and corresponding screencast here.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

🌞

• as a reviewer, I agree to behave in accordance with the review guidelines

[thegecko]

The code looks good to me, which desktop platforms does it need testing on?

[kittaakos]

which desktop platforms does it need testing on?

I experienced #5100 on macOS only, I do not know if it is an issue on Windows/Linux or not. The dynamic menu item related change (#446) should affect all supported platforms.

[thegecko]

I see no issue on MacOS

[paul-marechal]

Also it flickers when I click in the editor on Ubuntu 16.04, doesn't do it on master :/

(can't see it really well on the gif, but still a bit)

[akosyakov]

Seems to be a good approximation, won't work though if commands should be enabled/disabled based on internal widget state.

[kittaakos]

won't work though if commands should be enabled/disabled based on internal widget state

This. I will investigate VS Code's solution a bit more thoroughly.

Also it flickers when I click in the editor on Ubuntu 16.04, doesn't do it on master :/

Thanks for the feedback. I will try how VS Code behaves on my Ubuntu image and will compare it with Theia. Perhaps, I have to add some debouncing logic.

[kittaakos]

@akosyakov, I have dropped the dynamic electron menu part.
@marechal-p, could you please review the PR again. I have changed the window argument to electronWindow based on your feedback. Thank you!

[paul-marechal]

LGTM no more flickering on my side.