[plug-in] Improve plugin node.js error handling #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
benoitf
approved these changes
Jul 12, 2019
akosyakov
reviewed
Jul 12, 2019
| @@ -19,6 +19,54 @@ import { RPCProtocolImpl } from '../../api/rpc-protocol'; | |||
| import { PluginHostRPC } from './plugin-host-rpc'; | |||
| console.log('PLUGIN_HOST(' + process.pid + ') starting instance'); | |||
|
|
|||
| // override exit() function, to do not allow plugin kill this node | |||
There was a problem hiding this comment.
What node? Do you mean that a single plugin should not kill the plugin host process by calling nvm will assume that it meant to be node processprocess.ext?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR do next:
errorandexitevents on plugin runtime node.js instance.exitandcrashfunction in plugin runtime node.js instance, so plugin cannot terminate it's runtime.unhandledRejectionanduncaughtExceptionevents inside plugin runtime.This PR can be tested with this plugin bad-theia-plugin, it contains 3 commands with
Badprefix.