Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Init in current Workspace #6008

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Git Init in current Workspace #6008

merged 1 commit into from
Aug 23, 2019

Conversation

jbicker
Copy link
Contributor

@jbicker jbicker commented Aug 21, 2019

What it does

Fixes #5936
The current Workspace can be initialized as a Git Repository now.
git-init

How to test

Create a new Workspace and open it in theia.
Open the git view. You should see the note that there is no repository yet.
Hit the plus in the Git View Header.
Now you should see the Git View with the respective commit message field and so on.

Review checklist

Reminder for reviewers

@akosyakov
Copy link
Member

@akosyakov akosyakov added the git issues related to git label Aug 21, 2019
@jbicker jbicker force-pushed the git-init branch 2 times, most recently from 16cc64e to c4d924b Compare August 21, 2019 15:53
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested that:

  • scm toolbar items are available as before if a folder already contains a git repository;
  • only init repository is available if there is no git repository;
  • and that init repository command works properly.

Everything went alright for me, thank you!

packages/git/src/common/git.ts Outdated Show resolved Hide resolved
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker jbicker merged commit c36b2cf into master Aug 23, 2019
@jbicker jbicker deleted the git-init branch August 23, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SCM] Git init command
4 participants