fire JSON schema changed event if an underlying in-memory resource is changed

[akosyakov]

What it does

• fix change to launch schema by plugin system are not always recognized #6034: fire JSON schema changed event if an underlying in-memory resource is changed.

Otherwise JSON language server does not pick up content changes.

A bit off-topic:
I wonder why the host process has to be launched to recognize registered debuggers via metadata. Metadata from package.json should be recognized as soon as any VS Code extension is deployed. It could be that an extension code is not activated, but an extension still should contribute debug types and snippets for launch.json @tolusha Is it a bug?

How to test

• install node and node2 vscode extensions instead of native node debug extension
• open launch.json file
• make sure that it has node launch configuration and it is recognized
• refresh the page several times with opened launch.json file
• each time check that node launch configuration is eventually (as soon as VS Code extensions are loaded) recognized properly

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

@kpge Could you test whether it addresses #5804 as well?

[kpge]

@kpge Could you test whether it addresses #5804 as well?

no, it's still can't get the right suggestion when click Add Configuration in the launch.json

[akosyakov]

@kpge even if you wait a bit after opening? It could take time to fetch schemas, install them and reapply changes to json LS.

[kpge]

@kpge even if you wait a bit after opening? It could take time to fetch schemas, install them and reapply changes to json LS.

yes, I've opened the browser(didn't open a json file) or several minutes.
click 'Add Configuration' will open launch.json file and request triggerSuggest immediately; when sleep 200ms after opening the file , the suggestion will become correct
https://github.com/theia-ide/theia/blob/24bf9f28508f5b1244531605224e4b9ba424a9ba/packages/debug/src/browser/debug-configuration-manager.ts#L234

[a1994846931931]

Hi, what node and node2 vscode extensions are you referring to? Is it https://marketplace.visualstudio.com/items?itemName=ms-vscode.node-debug2 ?

[akosyakov]

@a1994846931931 https://marketplace.visualstudio.com/items?itemName=ms-vscode.node-debug2 and https://marketplace.visualstudio.com/items?itemName=ms-vscode.node-debug. they should be used together. I've updated the PR description.

[a1994846931931]

@akosyakov Sorry, I cannot reproduce #6034. I did the following:

1. Compile theia 144a1fe without debug-nodejs package;
2. Run backend and make sure that node launch configuration is invalid then;
3. Relaunch backend with ms-vscode.node-debug-1.38.4.vsix and ms-vscode.node-debug2-1.33.0.vsix;
4. With launch.json opened, refresh page several times and check the validity of node launch configuration;

But however I tried, the node launch configuration is always valid.