Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quick-pick initiated by the plugins not displaying with 1 item #6059

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Fix quick-pick initiated by the plugins not displaying with 1 item #6059

merged 1 commit into from
Aug 29, 2019

Commits on Aug 28, 2019

  1. Fix quick-pick initiated by the plugins not displaying with a single … 

    …item

Fixes #6050

- fixes issue where `quick-pick` which were initiated by the plugins was
not displayed when it only contains a single item. The fix is to include
a new flag `runIfSingle` which is used to determine if the quick-pick
should display or execute the item.
- The default value for `runIfSingle` is set to `true`.
- The `plugin-ext` sets the `runIfSingle` to `false` so it always displays
the quick-pick regardless if an single item is present. This behavior is aligned
with previous versions of Theia and VSCode.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
    @vince-fugnitto
    vince-fugnitto committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    f294597 View commit details
    Browse the repository at this point in the history