-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugin] Implement registerDeclarationProvider #6173
Conversation
Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. I don't see the error message anymore.
@akosyakov should this be added to change logs? |
I wonder how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes looks good to me
@svenefftinge It was added for cpp initially: microsoft/vscode#62483 Internet says: https://www.geeksforgeeks.org/difference-between-definition-and-declaration/ |
What it does
Implements missing DeclarationProvider API to allow recent versions of Python LS to work nicely.
Fixes #5213
How to test
"python.jediEnabled": false
to your preferencesimport os
(check content assist and go to declaration ofos
)output channel should contain something like:
Review checklist
Reminder for reviewers