Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cancellable option for withProgress #6365

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Fix cancellable option for withProgress #6365

merged 1 commit into from
Oct 11, 2019

Conversation

AlexTugarev
Copy link
Contributor

What it does

This PR makes the cancellable option being considered for withProgress notifications.

Fixes #5578

How to test

Screen Shot 2019-10-10 at 22 40 41

now the cancellable: false option should have the same effect as in vscode

Screen Shot 2019-10-10 at 22 10 26

Review checklist

Reminder for reviewers

@akosyakov akosyakov added progress issues related to the progress functionality vscode issues related to VSCode compatibility labels Oct 11, 2019
akosyakov
akosyakov approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot cancel progress anymore if cancellable is false. If true it still works.

@AlexTugarev
Fix cancellable option for withProgress
1be5d5c 
also cleaned up unused `NotificationMain.$startProgress` options.

Fixes #5578

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
@akosyakov
Copy link
Member

thx @AlexTugarev. looks simpler to me, works nicely as well

@AlexTugarev
Copy link
Contributor Author

thanks for reviewing!

@AlexTugarev AlexTugarev merged commit b98c5fb into master Oct 11, 2019
@vince-fugnitto vince-fugnitto deleted the GH-5578 branch September 29, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
progress issues related to the progress functionality vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(VS Code Extensions) window.withProgress isCancellable is not respected
2 participants
@AlexTugarev @akosyakov