Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open minibrowser without url encode #6388

Merged
merged 1 commit into from
Oct 15, 2019
Merged

open minibrowser without url encode #6388

merged 1 commit into from
Oct 15, 2019

Conversation

datou0412
Copy link
Contributor

@datou0412 datou0412 commented Oct 15, 2019

Signed-off-by: 二凢 dingyu.wdy@alibaba-inc.com

What it does

open minibrowser without url encode

How to test

inject a MiniBrowserOpenHandler as miniBrowserOpenHandler

this.miniBrowserOpenHandler.open(new URI('https://your.site.com?q=test'), options);

expect open a minibrowser with url "https://your.site.com?q=test" but got "https://your.site.com?q%3Dtest"

Review checklist

Reminder for reviewers

Signed-off-by: 二凢 <dingyu.wdy@alibaba-inc.com>
@akosyakov akosyakov added the mini-browser issues related to the mini-browser label Oct 15, 2019
@kittaakos
Copy link
Contributor

Very nice catch, @datou0412. It happens only and if only you explicitly call the open method with a URI and without the params. Otherwise, it works. That's why we did not hit this issue before. Thank you for the fix!

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified it locally, as I had to modify the code a little bit to be able to reproduce the defect. It worked as expected.

Thank you for your contribution, @datou0412!

@kittaakos kittaakos merged commit a3e6978 into eclipse-theia:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mini-browser issues related to the mini-browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants