[markdown-preview] resolve relative links properly #6403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest version of vscode-uir makes sure that URI always has a scheme or fall backs to `file` scheme and that URI is always absolute by adding leading `/` to the relative path. It broke an assumption that a URI can be relative in the markdown preview. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
vince-fugnitto
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fix #6396: resolve relative links properly
Latest version of vscode-uri makes sure that URI always has a scheme or falls back to
filescheme and that URI is always absolute by adding leading/to the relative path. It broke an assumption that a URI can be relative in the markdown preview.How to test
Review checklist
Reminder for reviewers