Fix https://github.com/eclipse-theia/theia/issues/6416 :: .editorconfig trim whitespace config not considered in manual save #6417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anual save Signed-off-by: Hemkaran Raghav <hemkaran.raghav@gmail.com>
|
@vitaliy-guliy @vince-fugnitto Hi, Can you please provide any ETA on the review of the PR? |
vince-fugnitto
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
@hemkaran it works well for me! 👍
Thank you for your contribution, I look forward to seeing more from you in the future :)
|
@vitaliy-guliy would you like to review as well or shall I merge? |
|
@hemkaran I'll merge since we no response was given, thank you very much for your contribution and we are looking forward to many more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fix for #6416
How to test
Explained in the issue
Review checklist
Reminder for reviewers