Filter debug console outputs by severity #6486
Conversation
| @@ -114,6 +123,50 @@ export class DebugConsoleContribution extends AbstractViewContribution<ConsoleWi | |||
| })); | |||
| } | |||
|
|
|||
| protected readonly SEVERITIES = ['Errors', 'Warnings', 'Info', 'Log']; | |||
There was a problem hiding this comment.
@tolusha I'm wondering, why not use the MessageType directly? I believe it would also remove the need to have
messageType + 1 and messageType - 1 in order places.
There was a problem hiding this comment.
@vince-fugnitto
What about MessageType.Progress severity? Should we use it?
There was a problem hiding this comment.
@vince-fugnitto
What aboutMessageType.Progressseverity? Should we use it?
I believe progress is mainly used for notifications, I don't believe it is useful in the context of debugging types. @AlexTugarev am I correct?
There was a problem hiding this comment.
This is confusing, but at least odd.
I'd rather derive the type of a message from a common severity than the other way around.
@tolusha and @akosyakov don't you think, this is a good chance to clean it up, i.e. to introduce Severity type in core?
There was a problem hiding this comment.
I guess it should be something like this
https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/severity.ts#L9
There was a problem hiding this comment.
It turned out we have it already
https://github.com/eclipse-theia/theia/blob/ab/severity/packages/task/src/common/problem-matcher-protocol.ts#L69
vince-fugnitto
added
console
|
@vince-fugnitto @AlexTugarev |
|
All remarks are fixed. I am going to squash commits and merge. |
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Signed-off-by: Anatoliy Bazko abazko@redhat.com
Reference issue
#6067
What it does
It supports filtering in debug console by severity.
How to test
#3Review checklist
Reminder for reviewers