Start Hosted Theia instance if Restart is called before Start #6521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doron Nahari <doron.nahari@sap.com>
akosyakov
requested review from
mmorhun,
azatsarynnyy,
benoitf,
evidolob and
vince-fugnitto
mmorhun
approved these changes
Nov 11, 2019
|
@mmorhun please help with merging if you are sure that everything is alright |
|
I tested it when I did the review, worked on my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Doron Nahari doron.nahari@sap.com
What it does
Related issues:
#3345
#3306
How to test
Restart hosted intance while there is no instance running and see that it's starts a new instance.
Review checklist
Reminder for reviewers