Fixes for Vscode emacs extension

[vinokurig]

Several fixes and adaptions that allow to use VsCode Emacs Keymap extension

What it does

• Do not throw an error if contributed keybinding is already registered. It would be added to map that can hold several keybindings with the same id.
• Iterate collision keybindings list from the last element like in VsCode: https://github.com/microsoft/vscode/blob/c2c643947bf18030c1af595e590cce6806aae0a5/src/vs/platform/keybinding/common/keybindingResolver.ts#L303
• If a partial keybinding is detected, use it in the higher priority https://github.com/eclipse-theia/theia/compare/che-9244?expand=1#diff-0291e1b92ff01c13c0dc1c98263ac426R624
• Allow to contribute keybindings separated by - https://github.com/eclipse-theia/theia/compare/che-9244?expand=1#diff-d076eb706720290d617fb0fd6f99c707R239
• Add necessary VsCode commands.

How to test

Apply VsCode Emacs Keymap extension
Tested Commands:

Move commands

• C-f | Move forward
• C-b | Move backward
• C-n | Move to the next line (in collision with browser keybinding)
• C-p | Move to the previous line
• C-a | Move to the beginning of line
• C-e | Move to the end of line
• M-f | Move forward by one word unit
• M-b | Move backward by one word unit
• M-> | Move to the end of buffer
• M-< | Move to the beginning of buffer
• C-v | Scroll down by one screen unit
• M-v | Scroll up by one screen unit
• M-g g | Jump to line (command palette)
• M-g n | Jump to next error
• M-g p | Jump to previous error
• C-l | Center screen on current line

Search Commands

• C-s | Search forward
• C-r | Search backward
• A-% | Replace
• C-Enter | Replace One Match (In replace dialog)
• C-M-n | Add selection to next find match

Edit commands

• C-d | Delete right (DEL)
• C-h | Delete left (BACKSPACE)
• M-d | Delete word
• M-Bksp | Delete word left
• C-k | Kill to line end (requires vscode cursorMove built-in command)
• C-S-Bksp | Kill entire line (requires vscode cursorMove built-in command)
• C-o | open-line
• C-w | Kill region (in collision with browser keybinding)
• M-w | Copy region to kill ring
• C-y | Yank (requires vscode lineBreakInsert built-in command)
• C-j | Enter (requires vscode lineBreakInsert built-in command)
• C-m | Enter (requires vscode lineBreakInsert built-in command)
• C-x C-o | Delete blank lines around
• C-x h | Select All
• C-x u (C-/, C-_) | Undo
• C-; | Toggle line comment in and out
• M-; | Toggle region comment in and out
• C-x C-l | Convert to lower case
• C-x C-u | Convert to upper case

Other Commands

• C-g | Cancel
• C-space | Set mark
• C-quote | IntelliSense Suggestion
• M-x | Open command palette
• C-M-SPC | Toggle SideBar visibility (requires vscode workbench.action.toggleSidebarVisibility built-in command)
• C-x z |  (requires vscode workbench.action.toggleZenMode built-in command)
• C-x r (requires vscode workbench.action.openRecent built-in command)

File Commands

• C-x C-s | Save
• C-x C-w | Save as (in collision with browser keybinding)
• C-x C-n | Open new window (in collision with browser keybinding)

Tab / Buffer Manipulation Commands

• C-x b | Switch to another open buffer
• C-x C-f | QuickOpen a file
• C-x k | Close current tab (buffer)
• C-x C-k | Close all tabs
• C-x 0 | Close editors in the current group.
• C-x 1 | Close editors in other (split) group.
• C-x 2 | Split editor horizontal (requires vscode workbench.action.splitEditorDown built-in command)
• C-x 3 | Split editor vertical (requires vscode workbench.action.splitEditorRight built-in command)
• C-x 4 | Toggle split layout (vertical to horizontal) (requires vscode workbench.action.toggleEditorGroupLayout built-in command)
• C-x o | Focus other split editor (requires vscode workbench.action.navigateEditorGroups built-in command)

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

@vinokurig test cases don't pass anymore.

Could someone review that changes to the core package does not cause any regressions?

[vinokurig]

@akosyakov fixed tests

[vinokurig]

@akosyakov @svenefftinge @vince-fugnitto any updates?

[akosyakov]

Code-wise changes look good to me, but someone have to test it.

[akosyakov]

@vinokurig don’t forget to clean up the history please

[akosyakov]

We discussed with @svenefftinge. There is a concern that we still want to see errors for collided default keybindings and try to treat them as before, i.e. without reversing order. An alternative less impactful approach could be to introduce a new scope between DEFAULT and USER, not sure how to name it. For this scope keybindings should be added in reverse order and collisions should be ignored to align with VS Code. @vinokurig Do you see any concerns with such approach?

[vinokurig]

@akosyakov I've added a PLUGIN scope and applied the previous logic to it according to you comment, could you please check?

[akosyakov]

yes, something like that

[vinokurig]

@akosyakov could you please check my latest comment: #6625 (comment)

[akosyakov]

@vinokurig very good analysis of keybindings, could you open a follow up issue summing up what still does not work and which VS Code commands we have to implement to support everything? We should also think how we can go about keybindings which are in collision with browser. I wonder does it work in VS Online and if not there is an issue in VS Code for it. Maybe they can introduce a new attribute to keybindings for web target.

[akosyakov]

It works nicely for me and I don't think it can break in the current state.

[vinokurig]

@akosyakov

could you open a follow up issue summing up what still does not work and which VS Code commands we have to implement to support everything?

I've added comments to existed issue: #4050 (comment) and #4050 (comment)

We should also think how we can go about keybindings which are in collision with browser.

Opened an issue: #6755

I wonder does it work in VS Online and if not there is an issue in VS Code for it. Maybe they can introduce a new attribute to keybindings for web target.

It doesn't work in VS Online as well and I've found a related issue in VsCode: microsoft/vscode#85252