Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about processId and terminalId to TaskExitedEvent #6825

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

RomanNikitenko
Copy link
Contributor

What it does

Add processId and terminalId to TaskExitedEvent.
These fields are available in TaskInfo while a task is running, would be nice to have this info when a task is completed. It can be useful to find the corresponding terminal widget, for example.

How to test

The PR changes do not provide a new functionality.
The fields are optional, so I think the PR doesn't bring the breaking changes.

Review checklist

Reminder for reviewers

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks the information is available in VS Code for all task events so I'm fine with the changes to make things easier: https://github.com/microsoft/vscode/blob/5418a564230e42b2f582f8ff961200eb052b695c/src/vs/workbench/contrib/tasks/common/tasks.ts#L970-L980

@vince-fugnitto vince-fugnitto added the tasks issues related to the task system label Jan 6, 2020
Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I had similar needs when I made other changes.

@RomanNikitenko RomanNikitenko merged commit df9c87b into master Jan 6, 2020
@RomanNikitenko RomanNikitenko deleted the taskExitedEvent branch January 6, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants