Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show empty debugger list when there isn't any debug config #6870

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Jan 13, 2020

What it does

This changes proposal doesn't show empty quick pick popup if there is no any debug configurations, this one:

Снимок экрана 2020-01-13 в 12 00 49

Old behavior:
debug

New behavior:
debug-fixed

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

How to test

Ensure that your workspace doesn't have launch.json, open any file in editor, place focus into editor and try to execute Debug > Start Debugging, you'll get empty quick pick popup and when it closes auto generated launch.json opens.

Review checklist

Reminder for reviewers

@vzhukovs vzhukovs added bug bugs found in the application debug issues that related to debug functionality labels Jan 13, 2020
@vzhukovs vzhukovs self-assigned this Jan 13, 2020
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better UX now 👍

@vince-fugnitto
Copy link
Member

@vzhukovskii I thought this case was already handled, this is what I see on master:

debugging

@vzhukovs
Copy link
Contributor Author

vzhukovs commented Jan 13, 2020

@vince-fugnitto, I suppose that this issue reproduces on 'heavy' projects, not sure, was testing this with che-theia project (theia built from master):

debugger-1

@vince-fugnitto
Copy link
Member

@vince-fugnitto, I suppose that this issue reproduces on 'heavy' projects, not sure, was testing this with che-theia project (theia built from master):

Unfortunately I could not reproduce the issue with a larger workspace, however I don't feel like your code will cause any problems and would be an overall better experience :)

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants