-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show empty debugger list when there isn't any debug config #6870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better UX now 👍
@vince-fugnitto, I suppose that this issue reproduces on 'heavy' projects, not sure, was testing this with che-theia project (theia built from master): |
Unfortunately I could not reproduce the issue with a larger workspace, however I don't feel like your code will cause any problems and would be an overall better experience :) |
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
What it does
This changes proposal doesn't show empty quick pick popup if there is no any debug configurations, this one:
Old behavior:
New behavior:
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
How to test
Ensure that your workspace doesn't have
launch.json
, open any file in editor, place focus into editor and try to executeDebug > Start Debugging
, you'll get empty quick pick popup and when it closes auto generatedlaunch.json
opens.Review checklist
Reminder for reviewers