Parallel resolve plugin entries #6972
Conversation
| for (const [dependency, deployableDependency] of dependencies) { | ||
| })); | ||
| for (const dependencies of dependenciesChunk) { | ||
| for (const [dependency, deployableDependency] of dependencies!) { |
There was a problem hiding this comment.
dependencies could be undefined and then you'll get "undefined is not iterable"
There was a problem hiding this comment.
Only non-undefined values seem to be pushed inside the array, doesn't seem to be any issue here. Typing could be refined earlier maybe.
There was a problem hiding this comment.
Right. So maybe change line 120 typing to be Array< Map<string, string>>
DoroNahari
force-pushed
the
paraller-resolve
branch
from
5abc81d
to
ea82d1b
Compare
|
For optimizations numbers should be provided before and after to see there it really makes the difference. Anyone should be able to follow steps in how to test and reproduce these numbers. |
Signed-off-by: Doron Nahari <doron.nahari@sap.com>
DoroNahari
force-pushed
the
paraller-resolve
branch
from
ea82d1b
to
3e14c58
Compare
Please see the updated |
|
@akosyakov Can it be merged? I'll be glad if it will be included in the next release (0.15.0) |
| } | ||
| visited.add(current); | ||
| } | ||
| queue = []; |
There was a problem hiding this comment.
why is it necessary? it can be reached only if length of queue is 0
|
@akosyakov yes 👍 |
Signed-off-by: Doron Nahari doron.nahari@sap.com
What it does
Our theia extension is loaded with high number of plugins causes the ide to be started but the plugins are not resolved/ready yet for a few minutes.
This pr resolve the plugins in parallel with regards to their dependencies. i.e. resolve all plugins and collect their dependencies and then resolve all the collected dependencies and so on.
Perfomance improvement:
By deploying java-pack vscode extension
Before:
After:
How to test
Add many plugins to Theia at once (preferred with dependencies) and see how they (and their dependencies) resolve in parallel.
For example: deploy vscode java pack: https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-java-pack and check out the console logs for deployment time.
I created a pr with old code and added same logs for comparing the performance: #6982
Review checklist
Reminder for reviewers