Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight is misspelled #7050

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Highlight is misspelled #7050

merged 1 commit into from
Feb 5, 2020

Conversation

garethwhittaker
Copy link
Contributor

What it does

Fixes: #7026
Corrects misspelling of highlight in a number of files.

How to test

Search within tree continues to highlight matches correctly.

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
I have a minor comment regarding updating the changelog.

Fixes: #7026

Signed-off-by: Gareth Whittaker <garethwhittaker@hotmail.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution 👍 I hope it's the first of many more

I verified and both the changes and functionality look good to me, thank you for also updating the changelog.

@vince-fugnitto vince-fugnitto merged commit 0c01098 into eclipse-theia:master Feb 5, 2020
@garethwhittaker garethwhittaker deleted the fix-highlight-typo branch February 6, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight is misspelled
2 participants